fix(sdk-metrics): collect metrics when periodic exporting metric reader flushes #3517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
force-pushed
the
metrics/flush
branch
from
e22a9dc
to
4e1565b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3517 +/- ##
=======================================
Coverage 93.80% 93.80%
=======================================
Files 249 249
Lines 7637 7640 +3
Branches 1589 1589
=======================================
+ Hits 7164 7167 +3
Misses 473 473
|
legendecas
force-pushed
the
metrics/flush
branch
from
4e1565b
to
0d7ce4a
Compare
pichlermarc
approved these changes
Jan 3, 2023
svetlanabrennan
approved these changes
Jan 3, 2023
dyladan
approved these changes
Jan 3, 2023
|
Does this also cause metrics to be collected on shutdown? |
|
@aabmass No. This PR addresses the change in open-telemetry/opentelemetry-specification#3084. To include effects of force flush in sdk shutdown, I've submitted open-telemetry/opentelemetry-specification#3085 and I can submit another PR to update it in JS SDK. |
|
Sounds good to me, thanks for following up! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #3278
Related spec issue: open-telemetry/opentelemetry-specification#2983
Short description of the changes
Type of change
How Has This Been Tested?
PeriodicExportingMetricReader.forceFlushcollects and exports metrics.Checklist: